On 11/05/2025 11:57, Adrian Hunter wrote: > On 25/04/2025 10:57, Adrian Hunter wrote: >> +static int tdx_terminate_vm(struct kvm *kvm) >> +{ >> + if (!kvm_trylock_all_vcpus(kvm)) > > Introduction of kvm_trylock_all_vcpus() is still in progress: > > https://lore.kernel.org/r/20250430203013.366479-3-mlevitsk@xxxxxxxxxx/ > > but it has kvm_trylock_all_vcpus(kvm) return value the other way around, so > this will instead need to be: > > if (kvm_trylock_all_vcpus(kvm)) > Sean, do you have any comments on this patch? Should I send out a new version with the change above? Note kvm_trylock_all_vcpus() now in Linus' tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=e4a454ced74c0ac97c8bd32f086ee3ad74528780