Re: [kvm-unit-tests v2 2/2] riscv: Add ISA double trap extension testing

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jun 05, 2025 at 11:52:14AM +0200, Clément Léger wrote:
...
> >> +	if (sbi_probe(SBI_EXT_SSE)) {
> >> +		if (sse_double_trap()) {
> >> +			report_skip("Could not correctly unregister SSE event, skipping last test");
> >> +			return;
> >> +		}
> >> +	} else {
> >> +		report_skip("SSE double trap event will not be tested, extension is not available");
> > 
> > Missing return
> 
> That's actually telling us it skipped the SSE + double trap test, not
> the rest of this function. So that should be kept without any return or
> we will skip the last test.
>

Ah, yes.

Thanks,
drew




[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux