Re: [PATCH v6 9/9] x86/nmi: Print source information with the unknown NMI console message

To: Sohil Mehta <sohil.mehta@xxxxxxxxx>, x86@xxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
Subject: Re: [PATCH v6 9/9] x86/nmi: Print source information with the unknown NMI console message
From: Xin Li <xin@xxxxxxxxx>
Date: Tue, 3 Jun 2025 09:55:32 -0700
Cc: "H . Peter Anvin" <hpa@xxxxxxxxx>, Andy Lutomirski <luto@xxxxxxxxxx>, Thomas Gleixner <tglx@xxxxxxxxxxxxx>, Ingo Molnar <mingo@xxxxxxxxxx>, Borislav Petkov <bp@xxxxxxxxx>, Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx>, Peter Zijlstra <peterz@xxxxxxxxxxxxx>, Sean Christopherson <seanjc@xxxxxxxxxx>, Adrian Hunter <adrian.hunter@xxxxxxxxx>, Kan Liang <kan.liang@xxxxxxxxxxxxxxx>, Tony Luck <tony.luck@xxxxxxxxx>, Zhang Rui <rui.zhang@xxxxxxxxx>, Steven Rostedt <rostedt@xxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, "Kirill A . Shutemov" <kirill.shutemov@xxxxxxxxxxxxxxx>, Jacob Pan <jacob.pan@xxxxxxxxxxxxxxxxxxx>, Andi Kleen <ak@xxxxxxxxxxxxxxx>, Kai Huang <kai.huang@xxxxxxxxx>, Sandipan Das <sandipan.das@xxxxxxx>, linux-perf-users@xxxxxxxxxxxxxxx, linux-edac@xxxxxxxxxxxxxxx, kvm@xxxxxxxxxxxxxxx, linux-pm@xxxxxxxxxxxxxxx, linux-trace-kernel@xxxxxxxxxxxxxxx
In-reply-to: <20250513203803.2636561-10-sohil.mehta@intel.com>
References: <20250513203803.2636561-1-sohil.mehta@intel.com> <20250513203803.2636561-10-sohil.mehta@intel.com>
User-agent: Mozilla Thunderbird

On 5/13/2025 1:38 PM, Sohil Mehta wrote:

+	if (cpu_feature_enabled(X86_FEATURE_NMI_SOURCE))
+		pr_emerg_ratelimited("NMI-source bitmap is 0x%lx\n", fred_event_data(regs));


"0x%04lx"?

Follow-Ups:
- Re: [PATCH v6 9/9] x86/nmi: Print source information with the unknown NMI console message
  - From: H. Peter Anvin
- Re: [PATCH v6 9/9] x86/nmi: Print source information with the unknown NMI console message
  - From: Sohil Mehta

References:
- [PATCH v6 0/9] x86: Add support for NMI-source reporting with FRED
  - From: Sohil Mehta
- [PATCH v6 9/9] x86/nmi: Print source information with the unknown NMI console message
  - From: Sohil Mehta