On Thu, May 29, 2025, Kai Huang wrote: > On Mon, 2025-05-19 at 16:27 -0700, Sean Christopherson wrote: > > Drop the superfluous kvm_hv_set_sint() and instead wire up ->set() directly > > to its final destination. > > kvm_hv_set_sint() is still there after this patch. Did you mean "superfluous > kvm_hv_synic_set_irq()"? :-) Ugh, yeah, bad changelog. Maybe this? Rename kvm_hv_synic_set_irq() to kvm_hv_set_sint() and drop the previous incarnation of kvm_hv_set_sint() provided by irq_comm.c, which is just a wrapper to the hyperv.c code. That said, given that the tracepoint is trace_kvm_hv_synic_set_irq(), and that the IOAPIC and PIC versions are kvm_ioapic_set_irq() and kvm_pic_set_irq() respectively, I'm leaning towards a straight drop of kvm_hv_set_sint(), i.e. keep kvm_hv_synic_set_irq().
