Re: [PATCH next V2] KVM: VMX: use __always_inline for is_td_vcpu and is_td

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 5/28/2025 5:48 AM, Huang, Kai wrote:
On Tue, 2025-05-27 at 17:53 +0000, Edgecombe, Rick P wrote:
On Tue, 2025-05-27 at 16:44 +0800, Edward Adam Davis wrote:
is_td() and is_td_vcpu() run in no instrumentation, so use __always_inline
to replace inline.

[1]
vmlinux.o: error: objtool: vmx_handle_nmi+0x47:
         call to is_td_vcpu.isra.0() leaves .noinstr.text section

Fixes: 7172c753c26a ("KVM: VMX: Move common fields of struct vcpu_{vmx,tdx} to a struct")
Signed-off-by: Edward Adam Davis <eadavis@xxxxxx>
---
V1 -> V2: using __always_inline to replace noinstr
Argh, for some reason the original report was sent just to Paolo and so I didn't
see this until now:
https://lore.kernel.org/oe-kbuild-all/202505071640.fUgzT6SF-lkp@xxxxxxxxx/

You (or Paolo) might want to add that link for [1]. Fix looks good.

Tested-by: Rick Edgecombe <rick.p.edgecombe@xxxxxxxxx>
Also,

Reviewed-by: Kai Huang <kai.huang@xxxxxxxxx>
Also,

Reviewed-by: Binbin Wu <binbin.wu@xxxxxxxxxxxxxxx>






[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux