> On May 8, 2025, at 3:57 PM, Babu Moger <babu.moger@xxxxxxx> wrote: > > Following changes are implemented in this series. > > 1. Fixed the cache(L2,L3) property details in all the EPYC models. > 2. Add RAS feature bits (SUCCOR, McaOverflowRecov) on all EPYC models > 3. Add missing SVM feature bits required for nested guests on all EPYC models > 4. Add the missing feature bit fs-gs-base-ns(WRMSR to {FS,GS,KERNEL_G}S_BASE is > non-serializing). This bit is added in EPYC-Genoa and EPYC-Turin models. > 5. Add RAS, SVM, fs-gs-base-ns and perfmon-v2 on EPYC-Genoa and EPYC-Turin models. > 6. Add support for EPYC-Turin. > (Add all the above feature bits and few additional bits movdiri, movdir64b, > avx512-vp2intersect, avx-vnni, prefetchi, sbpb, ibpb-brtype, srso-user-kernel-no). > > Link: https://www.amd.com/content/dam/amd/en/documents/epyc-technical-docs/programmer-references/57238.zip > Link: https://www.amd.com/content/dam/amd/en/documents/corporate/cr/speculative-return-stack-overflow-whitepaper.pdf > --- > v7: Rebased on top latest 57b6f8d07f14 (upstream/master) Merge tag 'pull-target-arm-20250506' > Added new feature bit PREFETCHI. KVM support for the bit is added recently. > https://github.com/kvm-x86/linux/commit/d88bb2ded2ef > Paolo, These patches have been pending for a while. Please consider merging when you get a chance. > > v6: Initialized the boolean feature bits to true where applicable. > Added Reviewed-by tag from Zhao. > > v5: Add EPYC-Turin CPU model > Dropped ERAPS and RAPSIZE bits from EPYC-Turin models as kernel support for > these bits are not done yet. Users can still use the options +eraps,+rapsize > to test these featers. > Add Reviewed-by tag from Maksim for the patches already reviewed. > > v4: Some of the patches in v3 are already merged. Posting the rest of the patches. > Dropped EPYC-Turin model for now. Will post them later. > Added SVM feature bit as discussed in > https://lore.kernel.org/kvm/b4b7abae-669a-4a86-81d3-d1f677a82929@xxxxxxxxxx/ > Fixed the cache property details as discussed in > https://lore.kernel.org/kvm/20230504205313.225073-8-babu.moger@xxxxxxx/ > Thanks to Maksim and Paolo for their feedback. > > v3: Added SBPB, IBPB_BRTYPE, SRSO_USER_KERNEL_NO, ERAPS and RAPSIZE bits > to EPYC-Turin. > Added new patch(1) to fix a minor typo. > > v2: Fixed couple of typos. > Added Reviewed-by tag from Zhao. > Rebased on top of 6d00c6f98256 ("Merge tag 'for-upstream' of https://repo.or.cz/qemu/kevin into staging") > > Previous revisions: > v6: https://lore.kernel.org/kvm/cover.1740766026.git.babu.moger@xxxxxxx/ > v5: https://lore.kernel.org/kvm/cover.1738869208.git.babu.moger@xxxxxxx/ > v4: https://lore.kernel.org/kvm/cover.1731616198.git.babu.moger@xxxxxxx/ > v3: https://lore.kernel.org/kvm/cover.1729807947.git.babu.moger@xxxxxxx/ > v2: https://lore.kernel.org/kvm/cover.1723068946.git.babu.moger@xxxxxxx/ > v1: https://lore.kernel.org/qemu-devel/cover.1718218999.git.babu.moger@xxxxxxx/ > > Babu Moger (6): > target/i386: Update EPYC CPU model for Cache property, RAS, SVM > feature bits > target/i386: Update EPYC-Rome CPU model for Cache property, RAS, SVM > feature bits > target/i386: Update EPYC-Milan CPU model for Cache property, RAS, SVM > feature bits > target/i386: Add couple of feature bits in CPUID_Fn80000021_EAX > target/i386: Update EPYC-Genoa for Cache property, perfmon-v2, RAS and > SVM feature bits > target/i386: Add support for EPYC-Turin model > > target/i386/cpu.c | 439 +++++++++++++++++++++++++++++++++++++++++++++- > target/i386/cpu.h | 4 + > 2 files changed, 441 insertions(+), 2 deletions(-) Hey Babu and Paolo, Is there anything outstanding on this series? I didn’t see any further comments. Anyhow, I did step thru this patch by patch, LGTM: Reviewed-By: Jon Kohler <jon@xxxxxxxxxxx <mailto:jon@xxxxxxxxxxx>>