Re: [PATCH] Fix comment for virtio-9p

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 27 May 2025 15:11:36 +0900,
Michael Tokarev wrote:
> 
> 27.05.2025 07:11, dancer@xxxxxxxxxx wrote:
> > From: Junichi Uekawa <uekawa@xxxxxxxxxxxx>
> > 
> > virtio-9p is not a console protocol, it's a file sharing protocol. Seems
> > like an artifact of old copy-and-paste error.
> 
> > -#define VIRTIO_ID_9P			9 /* 9p virtio console */
> > +#define VIRTIO_ID_9P			9 /* virtio 9p */
> 
> While the old one was obviously wrong, I don't think the new
> wording makes much sense, since it merely repeats the name of
> the constant :)
> 
> How about "virtio 9p file sharing protocol" instead ? :)

Sounds better!

I also found another case, added to the follow-up.







[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux