On Thu, 15 May 2025 22:51:16 +0300 Leon Romanovsky <leon@xxxxxxxxxx> wrote: > On Thu, May 15, 2025 at 11:47:15AM -0600, Alex Williamson wrote: > > On Tue, 13 May 2025 13:48:10 +0300 > > Leon Romanovsky <leon@xxxxxxxxxx> wrote: > > > > > Hi Alex, > > > > > > Please accept this pull request, which presents subset of new DMA-API > > > patchset [1] specific for VFIO subsystem. > > > > > > It is based on Marek's dma-mapping-for-6.16-two-step-api branch, so merging > > > now will allow us to reduce possible rebase errors in mlx5 vfio code and give > > > enough time to start to work on second driver conversion. Such conversion will > > > allow us to generalize the API for VFIO kernel drivers, in similiar way that > > > was done for RDMA, HMM and block layers. > > > > Hi Leon, > > > > Pull requests are not my typical workflow. Are these mlx5-vfio-pci > > changes intended to enter mainline through the vfio tree or your rdma > > tree? > > VFIO changes will come through your tree. DMA patches are the same as in > Marek's DMA tree and in our RDMA tree. Ok > I prepared PR to save from your hassle of merging dma/dma-mapping-for-6.16-two-step-api > topic from Marek and collecting VFIO patches from ML. > > > Why do the commits not include a review/ack from Yishai? > > They have Jason's review tags and as far as I know Yishai, he trusts > Jason's judgement. I don't doubt that, but Yishai is listed as the maintainer, so barring some special circumstances we should at least have an ack. > > Typically I'd expect a patch series for the mlx5-vfio-pci changes that > > I would apply, with Yishai's approval, to a shared branch containing the > > commits Marek has already accepted. I'm not sure why we're preempting > > that process here. Thanks, > > This is exactly what is in this PR: reviewed VFIO patches which were > posted to the ML on top of Marek's shared branch. > > If you prefer, I can repost the VFIO patches. I appreciate the attempt to streamline things and expect this largely only affects the chain of sign-off approvals, but at the same time that's an important aspect. If the code here is identical to v10, we could use that with Yishai's ack, but it's probably most direct (irony vs PR noted) to repost just just the mlx5-vfio-pci changes with a reference to Marek's shared topic branch. Thanks, Alex
