> On May 12, 2025, at 3:37 PM, Sean Christopherson <seanjc@xxxxxxxxxx> wrote: > > !-------------------------------------------------------------------| > CAUTION: External Email > > |-------------------------------------------------------------------! > > Please be more precise with the shortlogs. "Understand MBEC" is extremely vague. Ack, thanks for the feedback. I’ll tune it up across the board > > On Thu, Mar 13, 2025, Jon Kohler wrote: >> Adjust the SPTE_MMIO_ALLOWED_MASK and associated values to make these >> masks aware of PTE Bit 10, to be used by Intel MBEC. > > Same thing here. "aware of PTE bit 10" doesn't describe the change in a way that > allows for quick review of the patch. E.g. > > KVM: x86/mmu: Exclude EPT MBEC's user-executable bit from the MMIO generation > > The changelogs also need to explain *why*. If you actually tried to write out > justification for why KVM can't use bit 10 for the MMIO generation, then unless > you start making stuff up (or Chao and I are missing something), you'll come to > same conclusion that Chao and I came to: this patch is unnecessary. I’ll take a swing at it again, IIRC I couldn’t get it working without this, but I’ll page that back in and figure it out
