2025-05-07T17:31:33+05:30, Anup Patel <anup@xxxxxxxxxxxxxx>: > On Thu, Apr 3, 2025 at 5:02 PM Radim Krčmář <rkrcmar@xxxxxxxxxxxxxxxx> wrote: >> diff --git a/arch/riscv/include/asm/kvm_vcpu_sbi.h b/arch/riscv/include/asm/kvm_vcpu_sbi.h >> @@ -55,6 +55,8 @@ void kvm_riscv_vcpu_sbi_forward(struct kvm_vcpu *vcpu, struct kvm_run *run); >> void kvm_riscv_vcpu_sbi_system_reset(struct kvm_vcpu *vcpu, >> struct kvm_run *run, >> u32 type, u64 flags); >> +void kvm_riscv_vcpu_sbi_request_reset(struct kvm_vcpu *vcpu, >> + unsigned long pc, unsigned long a1); > > Use tabs for alignment instead of spaces. Oops, I totally forgot that linux uses tabs even for alignment. > Otherwise, it looks good to me. > I have taken care of the above comment at the time > of merging this patch. Thanks, I'll post v2 without the three patches.