On Tue, Apr 29, 2025 at 11:39:53PM +0530, Neeraj Upadhyay wrote: > My bad. I missed updating the changelog with the information about logic update. No, remember: when you move code like this, your first patch is *solely* *mechanical* move. Then, ontop, in further patches you do other changes. You want to keep mechanical move separate from other changes because it complicates review unnecessarily. One of the reasons I'm trying to get you guys to do review too is because then you'll know. Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette