On 5/1/25 12:30 PM, Philippe Mathieu-Daudé wrote:
On 1/5/25 08:23, Pierrick Bouvier wrote:
Associated code is protected by cpu_isar_feature(aa64*)
Signed-off-by: Pierrick Bouvier <pierrick.bouvier@xxxxxxxxxx>
---
target/arm/arch_dump.c | 6 ------
1 file changed, 6 deletions(-)
Should we assert() in the callees? Anyway,
I don't think so, as call sites are guarded by cpu_isar_feature(aa64_*).
I understand your repeated question on this topic, and I think a good
guideline could be to assert only when there are several call sites, or
call sites external to compilation units. For a static function called
in a single place, the risk to introduce a regression is quite low.
Reviewed-by: Philippe Mathieu-Daudé <philmd@xxxxxxxxxx>
