Re: [PATCH v3 17/33] target/arm/debug_helper: remove target_ulong

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 5/1/25 12:28 PM, Philippe Mathieu-Daudé wrote:
On 1/5/25 17:07, Richard Henderson wrote:
On 4/30/25 23:23, Pierrick Bouvier wrote:
Signed-off-by: Pierrick Bouvier <pierrick.bouvier@xxxxxxxxxx>
---
   target/arm/debug_helper.c | 2 +-
   1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/target/arm/debug_helper.c b/target/arm/debug_helper.c
index 357bc2141ae..50ef5618f51 100644
--- a/target/arm/debug_helper.c
+++ b/target/arm/debug_helper.c
@@ -381,7 +381,7 @@ bool arm_debug_check_breakpoint(CPUState *cs)
   {
       ARMCPU *cpu = ARM_CPU(cs);
       CPUARMState *env = &cpu->env;
-    target_ulong pc;
+    vaddr pc;

Why not directly use the symbol type (uint64_t)?


IIRC, Richard mentioned "use vaddr instead of uint64_t for pc" on another series.

       int n;
       /*

Reviewed-by: Richard Henderson <richard.henderson@xxxxxxxxxx>

r~






[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux