Re: [PATCH v5 3/7] x86/fpu/xstate: Differentiate default features for host and guest FPUs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Chao Gao <chao.gao@xxxxxxxxx>, <x86@xxxxxxxxxx>, <linux-kernel@xxxxxxxxxxxxxxx>, <kvm@xxxxxxxxxxxxxxx>, <tglx@xxxxxxxxxxxxx>, <dave.hansen@xxxxxxxxx>, <seanjc@xxxxxxxxxx>, <pbonzini@xxxxxxxxxx>
Subject: Re: [PATCH v5 3/7] x86/fpu/xstate: Differentiate default features for host and guest FPUs
From: "Chang S. Bae" <chang.seok.bae@xxxxxxxxx>
Date: Thu, 1 May 2025 07:24:25 -0700
Cc: <peterz@xxxxxxxxxxxxx>, <rick.p.edgecombe@xxxxxxxxx>, <weijiang.yang@xxxxxxxxx>, <john.allen@xxxxxxx>, <bp@xxxxxxxxx>, <xin3.li@xxxxxxxxx>, Ingo Molnar <mingo@xxxxxxxxxx>, Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx>, "H. Peter Anvin" <hpa@xxxxxxxxx>, "Maxim Levitsky" <mlevitsk@xxxxxxxxxx>, Samuel Holland <samuel.holland@xxxxxxxxxx>, Mitchell Levy <levymitchell0@xxxxxxxxx>, Eric Biggers <ebiggers@xxxxxxxxxx>, Stanislav Spassov <stanspas@xxxxxxxxx>, Vignesh Balasubramanian <vigbalas@xxxxxxx>, Aruna Ramakrishna <aruna.ramakrishna@xxxxxxxxxx>
In-reply-to: <20250410072605.2358393-4-chao.gao@intel.com>
References: <20250410072605.2358393-1-chao.gao@intel.com> <20250410072605.2358393-4-chao.gao@intel.com>
User-agent: Mozilla Thunderbird

On 4/10/2025 12:24 AM, Chao Gao wrote:


+struct vcpu_fpu_config guest_default_cfg __ro_after_init;

I just noticed that the patch set is missing the initialization ofguest_default_cfg.size = size (or legacy_size) in the following functions:


   fpu__init_system_xstate_size_legacy()
   fpu__init_disable_system_xstate()

Without that, it looks buggy when XSAVE is either unavailable or disabled.

Thanks,
Chang

Follow-Ups:
- Re: [PATCH v5 3/7] x86/fpu/xstate: Differentiate default features for host and guest FPUs
  - From: Chao Gao

References:
- [PATCH v5 0/7] Introduce CET supervisor state support
  - From: Chao Gao
- [PATCH v5 3/7] x86/fpu/xstate: Differentiate default features for host and guest FPUs
  - From: Chao Gao

Prev by Date: Re: [PATCH v5 5/7] x86/fpu: Initialize guest fpstate and FPU pseudo container from guest defaults
Next by Date: [Bug 220057] Kernel regression. Linux VMs crashing (I did not test Windows guest VMs)
Previous by thread: Re: [PATCH v5 3/7] x86/fpu/xstate: Differentiate default features for host and guest FPUs
Next by thread: Re: [PATCH v5 3/7] x86/fpu/xstate: Differentiate default features for host and guest FPUs
Index(es):
- Date
- Thread

[Index of Archives] [KVM ARM] [KVM ia64] [KVM ppc] [Virtualization Tools] [Spice Development] [Libvirt] [Libvirt Users] [Linux USB Devel] [Linux Audio Users] [Yosemite Questions] [Linux Kernel] [Linux SCSI] [XFree86]