Re: [PATCH v3 17/42] KVM: arm64: Handle trapping of FEAT_LS64* instructions

[Ben Horgan <ben.horgan@xxxxxxx>]

Hi Marc,

On 4/26/25 13:28, Marc Zyngier wrote:

> +	/*
> +	 * We only trap for two reasons:
> +	 *
> +	 * - the feature is disabled, and the only outcome is to
> +	 *   generate an UNDEF.
> +	 *
> +	 * - the feature is enabled, but a NV guest wants to trap the
> +	 *   feature used my its L2 guest. We forward the exception in
> +	 *   this case.
Nit: my -> by
> +	 *
> +	 * What we don't expect is to end-up here if the guest is
> +	 * expected be be able to directly use the feature, hence the
> +	 * WARN_ON below.
> +	 */


Thanks,

Ben