> > static void kvm_pmu_filter_class_init(ObjectClass *oc, void *data)
> > {
> > object_class_property_add_enum(oc, "action", "KvmPmuFilterAction",
> > @@ -116,6 +139,14 @@ static void kvm_pmu_filter_class_init(ObjectClass *oc, void *data)
> > NULL, NULL);
> > object_class_property_set_description(oc, "events",
> > "KVM PMU event list");
> > +
> > + object_class_property_add(oc, "x86-fixed-counter", "uint32_t",
> > + kvm_pmu_filter_get_fixed_counter,
> > + kvm_pmu_filter_set_fixed_counter,
> > + NULL, NULL);
> > + object_class_property_set_description(oc, "x86-fixed-counter",
> > + "Enablement bitmap of "
> > + "x86 PMU fixed counter");
>
> Adding that x86-specific field to all architectures is a bit dubious.
Similarly, do you think that it would be a good idea to wrap x86 related
codes in "#if defined(TARGET_I386)"? Like I said in this reply:
https://lore.kernel.org/qemu-devel/aA3TeaYG9mNMdEiW@xxxxxxxxx/
