On Thu, Apr 24, 2025, Sairaj Kodilkar wrote: > On 4/5/2025 1:08 AM, Sean Christopherson wrote: > > diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c > > index b8b259847d05..0ab818bba743 100644 > > --- a/arch/x86/kvm/x86.c > > +++ b/arch/x86/kvm/x86.c > > @@ -13567,6 +13567,43 @@ bool kvm_arch_has_irq_bypass(void) > > } > > EXPORT_SYMBOL_GPL(kvm_arch_has_irq_bypass); > > +static int kvm_pi_update_irte(struct kvm_kernel_irqfd *irqfd, > > + struct kvm_kernel_irq_routing_entry *old, > > the argument 'old' is redundant in this function. Ooh, and @new to kvm_x86_ops.pi_update_irte is also unused. I'll get rid of them both. I went through multiple iterations of hacking to figure out how to dedup the code, and (obviously) missed a few things when tidying up after the fact. Good eyes, and thanks again for the reviews! P.S. Please trim your replies.
