On Wed, Apr 23, 2025, Francesco Lavra wrote:
> On 2025-04-04 at 19:38, Sean Christopherson wrote:
> > @@ -876,20 +874,21 @@ int avic_pi_update_irte(struct kvm_kernel_irqfd
> > *irqfd, struct kvm *kvm,
> > * 3. APIC virtualization is disabled for the vcpu.
> > * 4. IRQ has incompatible delivery mode (SMI, INIT, etc)
> > */
> > - if (new && new->type == KVM_IRQ_ROUTING_MSI &&
> > - !get_pi_vcpu_info(kvm, new, &vcpu_info, &svm) &&
> > - kvm_vcpu_apicv_active(&svm->vcpu)) {
> > + if (new && new && new->type == KVM_IRQ_ROUTING_MSI &&
>
> The `&& new` part is redundant.
Ha, good job me. Better safe than sorry? :-)
