Thank you for reviewing my patches. On 4/11/2025 4:55 AM, Sean Christopherson wrote: > On Wed, Apr 09, 2025, Borislav Petkov wrote: >> On Wed, Apr 09, 2025 at 11:30:56AM +0530, Manali Shukla wrote: >>> Do you have concern with the decision to expose the flag to /proc/cpuinfo? >>> >>> The decision to expose the flag to /proc/cpuinfo was already discussed in >>> [v1]. As suggested in the discussion [v1], I have added "buslock" to be >>> enumerated in /proc/cpuinfo. >> >> If you mean this: >> >> https://lore.kernel.org/kvm/20240709175145.9986-4-manali.shukla@xxxxxxx/T/#m1dc7e08c54dd91d53a6bc5b1ed0a6721b356a756 >> >> I don't see any conclusion there. >> >> I see Sean wanting to export information out of KVM to say what it supports >> without adding user ABI and I don't know how far that has come > > Not very far :-( > >> but what you're >> doing here ain't it. >> >> Just do: >> >> #define X86_FEATURE_BUS_LOCK_THRESHOLD (15*32+29) /* Bus lock threshold */ >> >> and then later KVM can export this however it prefers. > > +1 Ack. I will remove "buslock". -Manali