Re: [PATCH v5 2/7] x86/fpu: Drop @perm from guest pseudo FPU container

To: Chao Gao <chao.gao@xxxxxxxxx>, <x86@xxxxxxxxxx>, <linux-kernel@xxxxxxxxxxxxxxx>, <kvm@xxxxxxxxxxxxxxx>, <tglx@xxxxxxxxxxxxx>, <dave.hansen@xxxxxxxxx>, <seanjc@xxxxxxxxxx>, <pbonzini@xxxxxxxxxx>
Subject: Re: [PATCH v5 2/7] x86/fpu: Drop @perm from guest pseudo FPU container
From: "Chang S. Bae" <chang.seok.bae@xxxxxxxxx>
Date: Fri, 18 Apr 2025 13:54:05 -0700
Cc: <peterz@xxxxxxxxxxxxx>, <rick.p.edgecombe@xxxxxxxxx>, <weijiang.yang@xxxxxxxxx>, <john.allen@xxxxxxx>, <bp@xxxxxxxxx>, <xin3.li@xxxxxxxxx>, Maxim Levitsky <mlevitsk@xxxxxxxxxx>, Ingo Molnar <mingo@xxxxxxxxxx>, Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx>, "H. Peter Anvin" <hpa@xxxxxxxxx>, Samuel Holland <samuel.holland@xxxxxxxxxx>, "Mitchell Levy" <levymitchell0@xxxxxxxxx>, Stanislav Spassov <stanspas@xxxxxxxxx>, "Eric Biggers" <ebiggers@xxxxxxxxxx>
In-reply-to: <cd14e94f-dbf8-4a2b-9e92-66dd23a3940b@intel.com>
References: <20250410072605.2358393-1-chao.gao@intel.com> <20250410072605.2358393-3-chao.gao@intel.com> <cd14e94f-dbf8-4a2b-9e92-66dd23a3940b@intel.com>
User-agent: Mozilla Thunderbird

On 4/18/2025 1:51 PM, Chang S. Bae wrote:

     if (xstate_get_guest_group_perm() & FPU_GUEST_PERM_LOCKED)
         fpu_lock_guest_permissions();


Sorry, this should be:

    if (!(xstate_get_guest_group_perm() & FPU_GUEST_PERM_LOCKED))
        fpu_lock_guest_permissions();

References:
- [PATCH v5 0/7] Introduce CET supervisor state support
  - From: Chao Gao
- [PATCH v5 2/7] x86/fpu: Drop @perm from guest pseudo FPU container
  - From: Chao Gao
- Re: [PATCH v5 2/7] x86/fpu: Drop @perm from guest pseudo FPU container
  - From: Chang S. Bae