On Wed, Apr 16, 2025 at 11:47 AM Sairaj Kodilkar <sarunkod@xxxxxxx> wrote: > I think it is safe to have this WARN_ON(!dev_data->use_vapic) without > any false positives. IOMMU driver sets the dev_data->use_vapic only when > the device is in UNMANAGE_DOMAIN and it is 0 if the device is in any > other domain (DMA, DMA_FQ, IDENTITY). > > We have a bigger problem from the VFIO side if we hit this WARN_ON() > as device is not in a UNMANGED_DOMAIN. This does seem safe, but its more of a VFIO/iommu change than a KVM one so I'm not too comfortable with merging it myself; please submit it as a separate patch. Paolo
