On 4/17/2025 4:22 PM, Thomas Gleixner wrote:
> On Thu, Apr 17 2025 at 14:46, Neeraj Upadhyay wrote:
>> +
>> +static inline void update_vector(unsigned int cpu, unsigned int offset,
>> + unsigned int vector, bool set)
>> +{
>> + unsigned long *reg = get_reg_bitmap(cpu, offset);
>> + unsigned int bit = get_vec_bit(vector);
>> +
>> + if (set)
>> + set_bit(bit, reg);
>> + else
>> + clear_bit(bit, reg);
>> +}
>
>> +static void savic_update_vector(unsigned int cpu, unsigned int vector, bool set)
>> +{
>> + update_vector(cpu, SAVIC_ALLOWED_IRR, vector, set);
>
> This indirection is required because otherwise the code is too simple to
> follow?
>
update_vector() is used by send_ipi_dest() in Patch 7. From your comment
on v3 https://lore.kernel.org/lkml/87y0whv57k.ffs@tglx/ , what I understood
was that you wanted update_vector() to be defined in the patch where that code
is added (i.e. this patch) and not at a later patch. Is that not correct
understanding?
- Neeraj
