Re: [PATCH 1/2] KVM: TDX: Handle TDG.VP.VMCALL<GetQuote>

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 4/15/2025 9:51 AM, Edgecombe, Rick P wrote:
On Tue, 2025-04-15 at 09:49 +0800, Xiaoyao Li wrote:
diff --git a/include/uapi/linux/kvm.h b/include/uapi/linux/kvm.h
index c6988e2c68d5..eca86b7f0cbc 100644
--- a/include/uapi/linux/kvm.h
+++ b/include/uapi/linux/kvm.h
@@ -178,6 +178,7 @@ struct kvm_xen_exit {
    #define KVM_EXIT_NOTIFY           37
    #define KVM_EXIT_LOONGARCH_IOCSR  38
    #define KVM_EXIT_MEMORY_FAULT     39
+#define KVM_EXIT_TDX_GET_QUOTE    41
Number 40 is skipped and I was told internally the reason is mentioned
in cover letter

      Note that AMD has taken 40 for KVM_EXIT_SNP_REQ_CERTS in the
      patch [4] under review, to avoid conflict, use number 41 for
      KVM_EXIT_TDX_GET_QUOTE and number 42 for
      KVM_EXIT_TDX_SETUP_EVENT_NOTIFY.

I think we shouldn't give up number 40 unless this series depends on AMD
one or it's agreement that AMD one will be queued/merged earlier.
Yes, if this patch needed to sit in kvm-coco-queue with AMD patches for awhile
it might make sense. But it sounds like the plan is to include it in base
support.
Right, now it seems that this patch could probably win the race upstream,
will use number 40 for KVM_EXIT_TDX_GET_QUOTE in the next version if no
objections.





[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux