Hi Jouni,
thanks for your review (and good to "hear" from you again)!
I have addressed your review with this PR:
https://github.com/suit-wg/suit-mti/pull/51
Regarding the note in Section 6 (IANA Considerations) saying that "A
recipient device that claims conformance to this document will have
implemented at least one of the above algorithms." we already state this
earlier in the document in Section 3. I prefer not to repeat it again.
Ciao
Hannes
Am 29.06.2025 um 10:09 schrieb Jouni Korhonen via Datatracker:
Document: draft-ietf-suit-mti
Title: Cryptographic Algorithm Recommendations for Software Updates of Internet
of Things Devices Reviewer: Jouni Korhonen Review result: Has Nits
I have done a review of this document as part of OPSDIR. I think the document
is ready with nits. Since I am not fluent with CDDL I cannot say much of the
correctness of Appendix A examples.
Editorial comments:
IDnits reports
** There are 31 instances of too long lines in the document, the longest
one being 11 characters in excess of 72.
These are likely Table 7. The long lines can be worked out with some effort.
The words can be cut or abbreviations can be used.
Line 17: s/suit/SUIT
The rest of the document seems to use SUIT not suit.
Line 99: Expand AEAD ("Authenticated encryption with associated data") on the
first use. Line 113: Expand AES-CTR on the first use, since it is also used on
body text not only in profile
tabled under a specifically referenced document.
Line 263: Expand HSS-LMS on the first use, since it is also used on body text
not only in profile
tabled under a specifically referenced document.
Line 330: Not necessay expand again SUIT as it is done already in the abstract.
Use just SUIT instead. Lines 335-363: consider making the table less wide. For
example, columns 'reference', 'encryption',
'key exchange' and 'status' are easy to take few characters away from
each.
Section 6: Earlier the algorithms listed in the table were referred as MTI
algorithm. I would add
such language in this section, not just saying "A recipient device
that claims conformance to this document will have implemented at
least one of the above algorithms."
Line 449: Expands CDDL on the first use.
_______________________________________________
Suit mailing list -- suit@xxxxxxxx
To unsubscribe send an email to suit-leave@xxxxxxxx
--
last-call mailing list -- last-call@xxxxxxxx
To unsubscribe send an email to last-call-leave@xxxxxxxx
