Hi all, Thanks Dhruv. @authors, please see one comment inline. @Druv, I also have a comment for you inline ;-) Cheers, Med > -----Message d'origine----- > De : Dhruv Dhody via Datatracker <noreply@xxxxxxxx> > Envoyé : jeudi 3 avril 2025 20:15 > À : yang-doctors@xxxxxxxx > Cc : draft-ietf-mboned-multicast-yang-model.all@xxxxxxxx; last- > call@xxxxxxxx; mboned@xxxxxxxx > Objet : Yangdoctors ietf last call review of draft-ietf-mboned- > multicast-yang-model-12 > > Document: draft-ietf-mboned-multicast-yang-model > Title: Multicast YANG Data Model > Reviewer: Dhruv Dhody > Review result: Not Ready > > # YANGDOCTORS LC Review of draft-ietf-mboned-multicast-yang-model- > 12 > > An LC review is requested but I see the document is not under WG > or IETF LC. > IMHO the I-D is not yet ready for LC and more work is needed. I > have noted various issues, this is not a complete list and I can > do another pass when the authors have made the update. > > ## YANG Model > > - Please update the file name with the latest date. It does not > match the revision date or the date in the copyright. > > - Use a shorter prefix - "ietf-multicast-model"; it is unusual to > have 'model' > in the name too. > > - Please add a better description for the YANG model in the YANG > file > > - Please use the correct boilerplate as per > https://trustee.ietf.org/documents/trust-legal-provisions/tlp-5/> [Med] As a generic guidance, not only the boilerplate, please use the module template at https://datatracker.ietf.org/doc/html/draft-ietf-netmod-rfc8407bis-22#name-template-for-ietf-modules. Also, use the security template at https://datatracker.ietf.org/doc/html/draft-ietf-netmod-rfc8407bis-22#name-security-considerations-sect for you Section 5. ... > > - Can you reuse the bier-encapsulation identity from draft-ietf- > bier-bier-yang, instead of defining a new grouping for it? ```` [Med] This will have a dependency implications to progress this spec. I'd like to avoid that. I checked draft-ietf-bier-bier-yang and I'm not confident about its stability. I suggest we don't implement this change (but fix it locally in the module to align/etc.). If this draft makes it before bier one, the reuse can be in the other way around. Thanks. ____________________________________________________________________________________________________________ Ce message et ses pieces jointes peuvent contenir des informations confidentielles ou privilegiees et ne doivent donc pas etre diffuses, exploites ou copies sans autorisation. Si vous avez recu ce message par erreur, veuillez le signaler a l'expediteur et le detruire ainsi que les pieces jointes. Les messages electroniques etant susceptibles d'alteration, Orange decline toute responsabilite si ce message a ete altere, deforme ou falsifie. Merci. This message and its attachments may contain confidential or privileged information that may be protected by law; they should not be distributed, used or copied without authorisation. If you have received this email in error, please notify the sender and delete this message and its attachments. As emails may be altered, Orange is not liable for messages that have been modified, changed or falsified. Thank you. -- last-call mailing list -- last-call@xxxxxxxx To unsubscribe send an email to last-call-leave@xxxxxxxx
