On Wed, Jun 04, 2025 at 01:36:53PM -0400, Mark Pearson wrote: > Create lenovo subdirectory for holding Lenovo specific drivers. ... > -F: drivers/platform/x86/lenovo-wmi-hotkey-utilities.c > +F: drivers/platform/x86/lenovo/lenovo-wmi-hotkey-utilities.c You may follow the trick in the Makefile (see intel folder) to avoid repetition of the folder name in the file names. Note, the modules will be called the same (assuming no ABI breakages due to renames). ... > -# IBM Thinkpad and Lenovo > +# IBM Thinkpad This is a bit ambiguous now. It's IBM and Lenove for ThinkPad... Perhaps you should put some kind of date or so? Like # IBM Thinkpad (before 2007) (note, I speculated on the year, you may know better what to put there). ... > +++ b/drivers/platform/x86/lenovo/Makefile > @@ -0,0 +1,15 @@ > +# SPDX-License-Identifier: GPL-2.0 > +# > +# Makefile for linux/drivers/platform/x86/lenovo > +# Lenovo x86 Platform-Specific Drivers > +# > +obj-$(CONFIG_IDEAPAD_LAPTOP) += ideapad-laptop.o > +obj-$(CONFIG_LENOVO_WMI_HOTKEY_UTILITIES) += lenovo-wmi-hotkey-utilities.o > +obj-$(CONFIG_LENOVO_YMC) += lenovo-ymc.o > +obj-$(CONFIG_THINKPAD_ACPI) += thinkpad_acpi.o > +obj-$(CONFIG_THINKPAD_LMI) += think-lmi.o > +obj-$(CONFIG_YOGABOOK) += lenovo-yogabook.o > +obj-$(CONFIG_YT2_1380) += lenovo-yoga-tab2-pro-1380-fastcharger.o > +obj-$(CONFIG_LENOVO_WMI_CAMERA) += lenovo-wmi-camera.o > + > + No need to have even a single blank line at the end of file. Usually editors even complain about this. -- With Best Regards, Andy Shevchenko _______________________________________________ ibm-acpi-devel mailing list ibm-acpi-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.sourceforge.net/lists/listinfo/ibm-acpi-devel
