Hi Peff
On 15/08/2025 00:14, Jeff King wrote:
On Sun, Aug 10, 2025 at 02:20:13PM +0100, Phillip Wood wrote:
On 10/08/2025 11:09, Phillip Wood wrote:
When I wrote earlier I forgot that git quotes filenames with control
characters. If a name contains a tab it it quoted and so cases 2 and 3 will
be quoted and so there is no ambiguity when trimming a literal tab character
from the end. I haven't checked but I suspect git-jump does not handle
quoted filenames, if we wanted to add support it should be pretty easy as
Git.pm has a function to do the unquoting for us.
Yeah, git-jump does not do any unquoting at all. Ironically I used the
"+++" line because I wanted to avoid quoting and whitespace headaches on
the "diff --git" line. But I guess it is unavoidable for truly weird
path names. ;)
I'd prefer to avoid an extra dependency on Git.pm and just leave it
broken for quoted names. Since names with spaces are the likely thing to
see, and those aren't quoted, I think running into this should be pretty
rare (another alternative is to lazy-load Git.pm only when necessary,
since we're already in a perl script).
I agree there's no pressing need to handle quoted names.
Thanks
Phillip
