Alexander Monakov <amonakov@xxxxxxxxx> writes: >> On Mon, 11 Aug 2025, Phillip Wood wrote: >> >> > > That's what the 'cycles' column in the table gives (6.21/5.8 = 1.070...) >> > >> > It would be helpful to add a column with those calculations in it rather than >> > forcing the reader to calculate the speed up for themselves. >> >> Ok, will change it to >> >> version | speedup over (A) | cycles, bn | instructions, bn >> ---------------------------------------------------------- >> A 6.38 11.3 >> B 1.027 6.21 10.89 >> C 1.1 5.80 9.95 >> D 1.094 5.83 8.74 >> ---------------------------------------------------------- > > On my Skylake: > > version | speedup over (A) | cycles, bn | instructions, bn > ---------------------------------------------------------- > A 5.77 10.96 > B 1.076 5.36 10.60 > C 1.12 5.16 9.66 > ---------------------------------------------------------- > > A is today's master, B and C are patch 1 and 1+2 like before. The thread has gone quiet. I assume everybody is happy with the result? Can we have a hopefully final v2 iteration of these patches, to address the updated to the table (this thread), to squelch the __asm__() issue [*asm*], and a reword you mentioned [*reword*] against Phillip's review? Thanks. *asm* https://lore.kernel.org/git/3405f274-cef1-b361-7424-840dc55b48a1@xxxxxxxxx/ *reword* https://lore.kernel.org/git/353c7865-d9b5-2a1c-4d71-cd1136581f01@xxxxxxxxx/