On Wed, Aug 20, 2025 at 06:39:54PM +0000, Derrick Stolee via GitGitGadget wrote: > diff --git a/t/t7700-repack.sh b/t/t7700-repack.sh > index 611755cc139b..1998d9bf291c 100755 > --- a/t/t7700-repack.sh > +++ b/t/t7700-repack.sh > @@ -838,4 +838,47 @@ test_expect_success '-n overrides repack.updateServerInfo=true' ' Tiny nit: I would've probably squashed this patch into the second patch, as we usually don't use the add-failing-test-and-then-fix-it-later dance. On the other hand though it gives some nice context, so I ultimately don't mind it all that much. So please feel free to ignore this nit. > test_server_info_missing > ' > > +test_expect_failure 'pending objects are repacked appropriately' ' > + git init pending && We probably also want `test_when_finished "rm -rf pending"` before calling git-init(1). > + > + ( > + cd pending && > + > + mkdir -p a/b && > + echo singleton >file && > + echo stuff >a/b/c && > + echo more >a/d && > + git add file a && > + git commit -m "single blobs" && > + > + echo d >a/d && > + echo e >a/e && > + git add a && > + git commit -m "more blobs" && > + > + # This use of a sparse index helps to force > + # test that the cache-tree is walked, too. > + git sparse-checkout set --sparse-index a x && > + > + # Just _stage_ the changes. > + echo f >a/d && > + echo h >a/e && > + echo i >a/i && > + mkdir x && > + echo y >x/y && > + git add a x && Nit: I think I would've moved the explanations you have in the commit message into these hunks so that the test becomes a bit more self-explanatory. > + # Bring the loose objects into a packfile to avoid > + # leftovers in next test. Without this, the loose > + # objects persist and the test succeeds for other > + # reasons. > + git repack -adf && > + git fsck && > + > + # Test path walk version with pack.useSparse. > + git -c pack.useSparse=true repack -adf --path-walk && > + git fsck > + ) > +' Patrick
