Re: [GSoC][PATCH 0/2] Add refs exists subcommand

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Aug 21, 2025 at 02:22:44PM +0530, Meet Soni wrote:
> This series introduces `git refs exists` as a modern replacement for
> `git show-ref --exists`, continuing the effort to consolidate commands
> under the `git refs` namespace.
> 
> The two patches are as follows:
> 
> 1. The first implements the `exists` subcommand. The small amount of
>    logic is duplicated from `show-ref` to avoid unnecessary abstraction.
> 
> 2. The second adds tests by refactoring the `show-ref --exists` tests
>    into a shareable helper, ensuring both commands are tested for
>    identical behavior.
> 
> Meet Soni (2):
>   builtin/refs: add 'exists' subcommand
>   t: add test for git refs exists subcommand
> 
>  Documentation/git-refs.adoc |  7 ++++
>  builtin/refs.c              | 48 +++++++++++++++++++++++++++
>  t/meson.build               |  3 +-
>  t/show-ref-exists-tests.sh  | 66 +++++++++++++++++++++++++++++++++++++
>  t/t1403-show-ref.sh         | 66 +------------------------------------
>  t/t1462-refs-exists.sh      | 22 +++++++++++++
>  6 files changed, 146 insertions(+), 66 deletions(-)
>  create mode 100644 t/show-ref-exists-tests.sh
>  create mode 100755 t/t1462-refs-exists.sh
> 
> 
> base-commit: c44beea485f0f2feaf460e2ac87fdd5608d63cf0
> prerequisite-patch-id: 235cc677f372e9571dade4313f8cfed4eab65f7f
> prerequisite-patch-id: d0cb9932dcf233b3a26e413514375191ede93c73
> prerequisite-patch-id: 9cb324ad34a786af110e9d3d47e4ca8aec240971
> prerequisite-patch-id: 0d74ac673c285c334adcc19b9ca2d4919563e804
> prerequisite-patch-id: 04c6d989f4130a063bc80f7dc9ce9a16d3459665
> prerequisite-patch-id: 95dafb2692da02d79c59cc2742258a915da25e88
> prerequisite-patch-id: f14c9a47038305eb3cfe8e9b649fa64065ada9cd
...

Feels like something went wrong here :)

What the cover letter doesn't mention explicitly is what the base of
this topic is. I assume it's probably v2.51.0 with ms/refs-list merged
into it?

Patrick




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux