Re: [PATCH 9/9] t: add gitdir encoding tests

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 18 Aug 2025, Junio C Hamano <gitster@xxxxxxxxx> wrote:
Adrian Ratiu <adrian.ratiu@xxxxxxxxxxxxx> writes:
Add some tests to further exercise the gitdir encoding functionality alongside the existing mixed directory and nested gitdir tests. Signed-off-by: Adrian Ratiu <adrian.ratiu@xxxxxxxxxxxxx> --- t/t7425-submodule-mixed-gitdir-paths.sh | 52 +++++++++++++++++++++++++ 1 file changed, 52 insertions(+) diff --git a/t/t7425-submodule-mixed-gitdir-paths.sh b/t/t7425-submodule-mixed-gitdir-paths.sh index 902b2560ca..cfdf487a56 100755 --- a/t/t7425-submodule-mixed-gitdir-paths.sh +++ b/t/t7425-submodule-mixed-gitdir-paths.sh @@ -152,4 +152,56 @@ test_expect_success 'checkout -f --recurse-submodules must corectly handle neste ... + longname=$(printf "%%%0.s" $(seq 1 $count)) &&

Use of 'seq' gets complaint from $ make -C t test-lint-shell-syntax See the commit message of d17cf5f3 (tests: Introduce test_seq, 2012-08-04) and b32c7ec0 (test-lib: teach test_seq the -f option, 2025-06-23). I think you should be able to do something like longname=$(test_seq -f "%%%0.s" 1 $count) && but I haven't even run the test with such a fix, so take it with a grain of salt, please.

Ack and thank you for the pointers. Will address in v2.




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux