Re: [PATCH v2] gitk: add README with usage, build, and contributing details

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Am 22.08.25 um 00:25 schrieb Michael Rappazzo:
> Signed-off-by: Michael Rappazzo <rappazzo@xxxxxxxxx>
> ---
> Changes from v1:
>  - Added Usage section with basic gitk command examples
>  - Simplified Contributing section by removing detailed patch workflow instructions
>  - Removed repository status and integration details

Thank you very much, this looks a lot better!

> 
>  README.md | 61 +++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 61 insertions(+)
>  create mode 100644 README.md
> 
> diff --git a/README.md b/README.md
> new file mode 100644
> index 0000000000..fd249bc24d
> --- /dev/null
> +++ b/README.md
> @@ -0,0 +1,61 @@
> +# gitk - The Git Repository Browser

Can we please write "Gitk" (uppercase "G") when we talk about the
software, not the command?

I would prefer an easy to read text file. Can we have underlined headers
where possible:

Gitk - The Git Repository Browser
=================================

Analogously for the subordinate headers below.

> +
> +gitk is a graphical Git repository browser. It displays the commit history of a Git repository as a graph, showing the relationships between commits, branches, and tags.
Please wrap the lines so that they don't exceed, say, 70 positions.

> +
> +## Usage
> +
> +To view the history of the current repository:
> +```bash
> +gitk
> +```
> +
> +To view the history of specific files or directories:
> +```bash
> +gitk path/to/file
> +gitk path/to/directory
> +```
> +
> +To view a specific branch or range of commits:
> +```bash
> +gitk branch-name
> +gitk v1.0..v2.0
> +```
> +
> +For more usage examples and options, see the [gitk manual](https://git-scm.com/docs/gitk).
> +
> +## Building
> +
> +gitk is a Tcl/Tk application. It requires Tcl/Tk to be installed on your system.
> +
> +### Running directly

At this point we should insert:

    Gitk can be run from the source directory without installation:

> +```bash
> +./gitk
> +```

    This is very convenient during development.

> +
> +### Installation
> +To install system-wide, you can use either `make` or `meson`:
> +
> +```bash
> +# Using Make
> +make install

This doesn't install system-wide, but in $HOME/bin. I am unsure whether
we should encourage this. AFAIC, I would be upset if this works without
sudo *and* clutters my $HOME. (I pull Gitk into the Git repository,
which I have patched to install in /usr/local.)

How do Gitk contributors handle `make install`?

> +
> +# Using Meson
> +meson setup builddir
> +meson compile -C builddir
> +meson install -C builddir
> +```

I haven't used the Meson infrastructure ever. I trust this procedure works.

> +
> +Both build systems will handle setting the correct Tcl/Tk interpreter path and installing translation files.
> +
> +## Contributing
> +
> +Contributions are welcome! The preferred method for submitting patches is via email to the Git mailing list, as this allows for more thorough review and broader community feedback. However, GitHub pull requests are also accepted.
> +
> +All commits must be signed off (use `git commit --signoff`) and should have commit messages prefixed with `gitk:`.
> +
> +#### Email Patches
> +Send patches to git@xxxxxxxxxxxxxxx and CC j6t@xxxxxxxx. See the Git project's [patch submission guidelines](https://git-scm.com/docs/SubmittingPatches) for detailed instructions on creating and sending patches.
> +
> +## License
> +
> +gitk is distributed under the GNU General Public License, either version 2, or (at your option) any later version.

Very good!

-- Hannes





[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux