Kyle Lippincott <spectral@xxxxxxxxxx> writes: > On Tue, Aug 26, 2025 at 4:35 PM David Aguilar <davvid@xxxxxxxxx> wrote: >> >> "make -JN" with INCLUDE_LIBGIT_RS enabled causes cargo lock warnings >> and can trigger ld errors during the build. >> >> The build errors are caused by two inner "make" invocations getting >> triggered concurrently: once inside of libgit-sys and another inside of >> libgit-rs. >> >> Make libgit-rs depend on libgit-sys so that "make" prevents them >> from running concurrently. Apply the same logic to the test invocations. >> Use cargo's "--manifest-path" option instead of "cd" in the recipes. >> .... >> + $(QUIET)cargo test --manifest-path ../contrib/libgit-sys/Cargo.toml >> +libgit-rs-test: libgit-sys-test >> + $(QUIET)cargo test --manifest-path ../contrib/libgit-rs/Cargo.toml >> ifdef INCLUDE_LIBGIT_RS >> -all:: libgit-sys-test libgit-rs-test >> +all:: libgit-rs-test >> endif >> -- >> 2.50.0.7.ge90cf88798 > > This version looks good to me, thanks! Thanks, both. Will apply.
