Re: [PATCH v2 13/16] packfile: move `get_multi_pack_index()` into "midx.c"

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Aug 21, 2025 at 09:39:11AM +0200, Patrick Steinhardt wrote:
> The `get_multi_pack_index()` function is declared and implemented in the
> packfile subsystem, even though it really belongs into the multi-pack
> index subsystem. The reason for this is likely that it needs to call
> `packfile_store_prepare()`, which is not exposed by the packfile system.
> In a subsequent commit we're about to add another caller outside of the
> packfile system though, so we'll have to expose the function anyway.
>
> Do so now already and move `get_multi_pack_index()` into the MIDX
> subsystem.

Makes sense.

> Signed-off-by: Patrick Steinhardt <ps@xxxxxx>
> ---
>  midx.c     |  6 ++++++
>  midx.h     |  2 ++
>  packfile.c |  8 +-------
>  packfile.h | 10 +++++++++-
>  4 files changed, 18 insertions(+), 8 deletions(-)

And all looks good here.

Thanks,
Taylor




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux