Re: [PATCH v4 1/2] t/t1517: automate `git subcmd -h` tests outside a repository

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Ben

On 28/08/2025 14:47, D. Ben Knoble wrote:
On Tue, Aug 26, 2025 at 12:04 PM Phillip Wood <phillip.wood123@xxxxxxxxx> wrote:

+for cmd in $(git --list-cmds=main)

This lists all the git commands in $PATH which is causing "make test" to
fail when I run it locally as it is testing all my local "git-*" scripts
most of which apparently fail this test. If there isn't already we
should add a option that lists the commands only in $GIT_EXEC_PATH and
use it here.

That should only happen if you set GIT_TEST_INSTALLED or something,
right? Or maybe some even more exotic setup: even with my
distro-installed Git, the command doesn't list my git-* scripts in
$PATH or installed extensions (like git-when-merged).

Sorry for the confusion, I've just had another look and it turns out I had some rubbish laying around in the root of my repository which was causing the problem.

Also when I run the test with '-i' it does not stop at the first
failure. I'm not sure what's causing that as I thought
test_expect_success should exit on failure even when it is called in a loop.

That's odd: when I make some modifications that cause a failure and
run with "-i," it does stop early. Hm.

Thanks for looking carefully! I'm personally having a hard time
reproducing the issue though :/

Hmm, I'm not sure what was happening, at the time it looked like the loop was continuing but I can't reproduce it either now.

Thanks for taking a look and sorry for the noise

Phillip




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux