Re: [PATCH v3 02/15] odb: move list of packfiles into `struct packfile_store`

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Sep 09, 2025 at 01:00:53AM -0700, Karthik Nayak wrote:
> Patrick Steinhardt <ps@xxxxxx> writes:
> 
> > @@ -789,8 +784,8 @@ void install_packed_git(struct repository *r, struct packed_git *pack)
> >  	if (pack->pack_fd != -1)
> >  		pack_open_fds++;
> >
> > -	pack->next = r->objects->packed_git;
> > -	r->objects->packed_git = pack;
> > +	pack->next = r->objects->packfiles->packs;
> > +	r->objects->packfiles->packs = pack;
> >
> 
> So this is where we insert the packfile into the packfile_store. Okay
> makes sense.
> 
> > +/*
> > + * Close all packfiles associated with this store. The packfiles won't be
> > + * free'd, so they can be re-opened at a later point in time.
> > + */
> > +void packfile_store_close(struct packfile_store *store);
> > +
> >
> 
> One immediate question is, how can someone reopen the closed packfiles.
> Is that something that the packfile store should offer?

There is no specific use case for this right now. Packfiles get reopened
automatically as needed when looking up objects.

Patrick




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux