On Wed, Aug 13, 2025 at 11:45 AM Junio C Hamano <gitster@xxxxxxxxx> wrote: > > Phillip Wood <phillip.wood123@xxxxxxxxx> writes: > > > Hi Ben > > > > On 12/08/2025 18:02, D. Ben Knoble wrote: > >> Changes from v3: > >> - drop 4/4 > >> - use test_env (including a case our lint does not catch when the value > >> has spaces) > > > > It's not worth a re-roll but for future reference > > > > test_env FOO=bar git commit --amend > > > > uses an extra process compared to > > > > FOO=bar git commit --amend > > > > which slows the test suite down for no real gain. We should only need > > to use test_env to set environment variables when calling a shell > > function. In the special case of test_must_fail it supports > > > > test_must_fail env FOO=bar git commit --amend > > > > which is widely used in our test suite Aha, I learned something new (again)—although that still means my diagnosis for this about the space in the value is wrong :) It's not flagged because it's not a shell function. Great! > If this were some feature series, the story may be different, but > since the theme of the topic is "clean up", the above clean-up is > something that ought to be part of an update. A clean-up topic > should not be adding things that need to be further cleaned up ;-) Agreed; I don't want to add more problems here ;)
