On Mon, Aug 11, 2025 at 8:16 PM Eric Sunshine <sunshine@xxxxxxxxxxxxxx> wrote: > > On Mon, Aug 11, 2025 at 6:59 PM Ben Knoble <ben.knoble@xxxxxxxxx> wrote: > > > Le 11 août 2025 à 18:17, D. Ben Knoble <ben.knoble+github@xxxxxxxxx> a écrit : > > > Changes from v2: > > > - shuffle setup code and use more helpers in 1/4 > > > - insert 2/4 to stop abusing --exec-path > > > - improve environment-cleansing idioms in {2 => 3}/4 > > > > Some of this shuffling turned out to be unportable, which CI caught (but running the test locally didn’t??). Fortunately it pointed me at test_env and I’ll either use it or go back to the subshells. > > To catch it locally, you can run: > > make test-lint-shell-syntax > > in the "t" directory. Alternatively, `make test-lint`, `make test` or > `make prove` would also have caught the problem. Ah, thanks. I was particularly confused because running the test file directly does run the chainlint check, I think, but not this lint. -- D. Ben Knoble