Hi,
this small patch series contains a couple of improvements I required for
libgit2. With those changes libgit2 is now able to run its full test
suite with reftable-enabled repositories. I still need to invest a bit
of work to make it memory-leak free and compile on Windows, but overall
I think that support for reftables is almost ready.
Changes in v2:
- Another commit that fixes handling of outdated stacks when doing
compaction. This issue is hit in libgit2, which has a test that
performs writes with a couple dozen concurrent threads.
- Add a link to past discussions around `{0}` vs `{{0}}` as provided
by Eric.
- Link to v1: https://lore.kernel.org/r/20250801-pks-reftable-fixes-for-libgit2-v1-0-f446e1c33cb9@xxxxxx
Changes in v3:
- Adapt `reftable_stack_init_addition()` to `memset()` the addition
instead of using `{{0}}`.
- Add another commit on top that makes the `flock` interface more
robust by not relying on `errno`.
- Add another commit to fix races with concurrent writers caused by
the backend not passing `REFTABLE_STACK_NEW_ADDITION_RELOAD`.
- Link to v2: https://lore.kernel.org/r/20250804-pks-reftable-fixes-for-libgit2-v2-0-fef06209a984@xxxxxx
Thanks!
Patrick
---
Patrick Steinhardt (8):
reftable/writer: fix type used for number of records
reftable/writer: drop Git-specific `QSORT()` macro
reftable/stack: reorder code to avoid forward declarations
reftable/stack: fix compiler warning due to missing braces
reftable/stack: allow passing flags to `reftable_stack_add()`
reftable/stack: handle outdated stacks when compacting
reftable: don't second-guess errors from flock interface
refs/reftable: always reload stacks when creating lock
refs/reftable-backend.c | 23 ++-
reftable/reftable-stack.h | 9 +-
reftable/reftable-writer.h | 4 +-
reftable/stack.c | 439 +++++++++++++++++++---------------------
reftable/system.c | 2 +-
reftable/system.h | 4 +-
reftable/writer.c | 23 ++-
t/unit-tests/t-reftable-stack.c | 50 ++---
8 files changed, 275 insertions(+), 279 deletions(-)
Range-diff versus v2:
1: ce08ba1217 = 1: 1613715dc9 reftable/writer: fix type used for number of records
2: 80a87ff19a = 2: 4a082b71fb reftable/writer: drop Git-specific `QSORT()` macro
3: e230c97347 < -: ---------- reftable/stack: fix compiler warning due to missing braces
4: dd413b76a2 ! 3: 3977a1f497 reftable/stack: reorder code to avoid forward declarations
@@ reftable/stack.c: int reftable_stack_reload(struct reftable_stack *st)
struct reftable_stack *stack;
@@ reftable/stack.c: struct reftable_addition {
- #define REFTABLE_ADDITION_INIT {{0}}
+ #define REFTABLE_ADDITION_INIT {0}
+static void reftable_addition_close(struct reftable_addition *add)
+{
-: ---------- > 4: e8424dd2ee reftable/stack: fix compiler warning due to missing braces
5: 494bbd6c97 ! 5: 4f0f5cd8e1 reftable/stack: allow passing flags to `reftable_stack_add()`
@@ reftable/stack.c: static int reftable_stack_init_addition(struct reftable_additi
- void *arg)
+ void *arg, unsigned flags)
{
- struct reftable_addition add = REFTABLE_ADDITION_INIT;
-- int err = reftable_stack_init_addition(&add, st, 0);
-+ int err = reftable_stack_init_addition(&add, st, flags);
+ struct reftable_addition add;
+ int err;
+
+- err = reftable_stack_init_addition(&add, st, 0);
++ err = reftable_stack_init_addition(&add, st, flags);
if (err < 0)
goto done;
6: 46411bf2c2 = 6: e6e06c8d34 reftable/stack: handle outdated stacks when compacting
-: ---------- > 7: 86d57dad6e reftable: don't second-guess errors from flock interface
-: ---------- > 8: b7bb745ffb refs/reftable: always reload stacks when creating lock
---
base-commit: e813a0200a7121b97fec535f0d0b460b0a33356c
change-id: 20250801-pks-reftable-fixes-for-libgit2-562b959a5603
