In the case where one pushes a non-existent oid to an unqualified
destination, we encounter the following BUG
error: The destination you provided is not a full refname (i.e.,
starting with "refs/"). We tried to guess what you meant by:
- Looking for a ref that matches 'branch' on the remote side.
- Checking if the <src> being pushed ('0000000000000000000000000000000000000001')
is a ref in "refs/{heads,tags}/". If so we add a corresponding
refs/{heads,tags}/ prefix on the remote side.
Neither worked, so we gave up. You must fully qualify the ref.
BUG: remote.c:1221: '0000000000000000000000000000000000000001' should be commit/tag/tree/blob, is '-1'
fatal: the remote end hung up unexpectedly
Aborted (core dumped)
However, this isn't actually a bug so replace it with an advise()
message.
Changes since v4:
* Put the switch statement refactoring patch last so that we don't get
compile errors from a missing variable
Changes since v3:
* Include the switch statement refactoring patch as a prelude to the
functional patch
* Change "if-else tower" to "if-else ladder"
* Shortened the overly long advise() line
* Rebased on latest 'master' to avoid merge conflict introduced earlier
in the merge cycle (this should be fine since we haven't merged to
'next' yet right?)
Changes since v2:
* Add t5516 cleanup patch
* Squash test creation patch into the patch that fixes it
* Include the erroneous object ID in the advise message
Denton Liu (3):
t5516: remove surrounding empty lines in test bodies
remote.c: remove BUG in show_push_unqualified_ref_name_error()
remote.c: convert if-else ladder to switch
remote.c | 24 +++++++++++--------
t/t5516-fetch-push.sh | 54 ++++---------------------------------------
2 files changed, 19 insertions(+), 59 deletions(-)
Range-diff against v4:
1: d31f320fdb = 1: d31f320fdb t5516: remove surrounding empty lines in test bodies
3: 3d84072dc7 ! 2: d21612fca6 remote.c: remove BUG in show_push_unqualified_ref_name_error()
@@ Commit message
## remote.c ##
@@ remote.c: static void show_push_unqualified_ref_name_error(const char *dst_value,
+ "'%s:refs/tags/%s'?"),
matched_src_name, dst_value);
- break;
- default:
+ } else {
- BUG("'%s' should be commit/tag/tree/blob, is '%d'",
- matched_src_name, type);
+ advise(_("The <src> part of the refspec ('%s') "
+ "is an object ID that doesn't exist.\n"),
+ matched_src_name);
-+ break;
}
}
2: ee6d69bcaf ! 3: cbda61af5c remote.c: convert if-else ladder to switch
@@ remote.c: static void show_push_unqualified_ref_name_error(const char *dst_value
- } else {
+ break;
+ default:
- BUG("'%s' should be commit/tag/tree/blob, is '%d'",
- matched_src_name, type);
+ advise(_("The <src> part of the refspec ('%s') "
+ "is an object ID that doesn't exist.\n"),
+ matched_src_name);
++ break;
}
+ }
+
--
2.50.1
