Patrick Steinhardt <ps@xxxxxx> writes: >> + default: >> + BUG("%d: not a valid output format", format); > > Nit: we typically say it the other way round. > > BUG("not a valid output format: %d", format); It is in the coding guidelines - Say what the error is first ("cannot open '%s'", not "%s: cannot open"). but sometimes we forget. Thanks for good eyes.