Re: [GSoC PATCH v8 5/5] repo: add the --format flag

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Patrick Steinhardt <ps@xxxxxx> writes:

>> +		default:
>> +			BUG("%d: not a valid output format", format);
>
> Nit: we typically say it the other way round.
>
> 	BUG("not a valid output format: %d", format);

It is in the coding guidelines

 - Say what the error is first ("cannot open '%s'", not "%s: cannot open").

but sometimes we forget.  Thanks for good eyes.





[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux