Re: [PATCH 6/8] midx: write multi-pack indices via their source

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Patrick Steinhardt <ps@xxxxxx> writes:

[snip]

> diff --git a/midx-write.c b/midx-write.c
> index 37a0b1682f..bf7c01d4b1 100644
> --- a/midx-write.c
> +++ b/midx-write.c
> @@ -913,15 +913,6 @@ static int write_midx_bitmap(struct write_midx_context *ctx,
>  	return ret;
>  }
>
> -static struct multi_pack_index *lookup_multi_pack_index(struct repository *r,
> -							const char *object_dir)
> -{
> -	struct odb_source *source = odb_find_source(r->objects, object_dir);
> -	if (!source)
> -		die(_("could not find object directory matching %s"), object_dir);
> -	return get_multi_pack_index(source);
> -}
> -
>

Since we now directly pass the source, there is no need to find it from
the repository. Makes sense.

[snip]

The rest of the patch, simply replaces the 'repository' object with the
'odb_source' object. This makes things a lot more contained and is
indeed a much nicer flow of information.

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux