On Fri, Aug 01, 2025 at 01:38:16PM +0200, Toon Claes wrote: > Patrick Steinhardt <ps@xxxxxx> writes: > > > In a subsequent commit we'll add another user that wants to write reflog > > entries. This requires them to call `ref_transaction_update_reflog()`, > > but that function is local to "refs.c". > > > > Export the function to prepare for the change. While at it, drop the > > `flags` field, as all callers are for now expected to use the same flags > > anyway. > > > > Signed-off-by: Patrick Steinhardt <ps@xxxxxx> > > --- > > refs.c | 29 +++++++++++------------------ > > refs.h | 15 +++++++++++++++ > > 2 files changed, 26 insertions(+), 18 deletions(-) > > > > diff --git a/refs.c b/refs.c > > index dce5c49ca2b..8aa9f7236a3 100644 > > --- a/refs.c > > +++ b/refs.c > > @@ -1371,27 +1371,21 @@ int ref_transaction_update(struct ref_transaction *transaction, > > return 0; > > } > > > > -/* > > - * Similar to`ref_transaction_update`, but this function is only for adding > > Tiniest nit: for some reason the space after "to" fell away. This is the preimage though :) I've fixed it in the postimage already. Patrick