Re: [GSoC PATCH v7 3/5] repo: add the field layout.bare

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Aug 3, 2025 at 6:54 PM Lucas Seiki Oshiro
<lucasseikioshiro@xxxxxxxxx> wrote:
> > The quote placement used in these calls to `test_repo_info` is quite
> > unusual and more than a little confusing. I'm guessing you did it this
> > way to avoid having to use a backslash to continue the line or did it
> > to mimic how `test_expect/fail` is called
>
> Yeah, that's true :-). I'll change it. However, in the next patch, where
> I add `repository.shallow`, I need a more complex script for creating
> a shallow repository which needs several lines. In this case, do you
> think it would it be better to use the backslash before the line break
> or would it be like it currently is?

If you take the suggestion I made in my review[*] of that subsequent
patch (specifically, create a separate "setup"-style test), then I'm
pretty sure you won't need to use the complex script for the function
argument; it should collapse to a single line as shown in [*].

[*]: https://lore.kernel.org/git/CAPig+cTtJHn3NxrXF-AU_0cRzccDOo+j8JTAq1Jyqm4BzXBpSw@xxxxxxxxxxxxxx/





[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux