> > Hm—if we strip the suffix with ${cmd%.*}, do we need a p4.py pattern > > too? Actually, at first I wondered why we need to strip the suffix at > > all. My local Git produces only unsuffixed commands. But > > bin-wrappers/git produces both p4 and p4.py; request-pull and > > request-pull.sh; and several others. So I think stripping is probably > > right, just drop the .py pattern. > > I think that using "instaweb.sh" instead of "instaweb" also causes > this to fail on Windows, like: > > https://github.com/benknoble/git/actions/runs/16695826272/job/47259908953 I think this is expected breakage. Removing ".sh" makes the #TODO to pass. > > -- > D. Ben Knoble