Re: [PATCH v2 05/11] merge-tree: do not use strbuf_split*()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jul 31, 2025 at 03:54:27PM -0700, Junio C Hamano wrote:

> -			if (input_merge_base && split[2] && split[3] && !split[4]) {
> [...]
> +			if (input_merge_base && split.nr == 4) {

I always hated strbuf_split() because the array-of-strbufs was awkward
to work with. But I never realized how inconvenient it was not to have
the count of split items until seeing that monstrosity in the pre-image. ;)

-Peff




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux