On Thu, Jul 31, 2025 at 02:30:37PM +0530, Meet Soni wrote: > diff --git a/builtin/for-each-ref.c b/builtin/for-each-ref.c > index 3d2207ec77..bbc0e5ad1c 100644 > --- a/builtin/for-each-ref.c > +++ b/builtin/for-each-ref.c > @@ -7,19 +7,9 @@ > #include "ref-filter.h" > #include "strbuf.h" > #include "strvec.h" > +#include "for-each-ref.h" Let's keep the includes alphabetically sorted. > diff --git a/t/t0450/adoc-help-mismatches b/t/t0450/adoc-help-mismatches > index 06b469bdee..2c6ecd5fc8 100644 > --- a/t/t0450/adoc-help-mismatches > +++ b/t/t0450/adoc-help-mismatches > @@ -17,7 +17,6 @@ fast-export > fast-import > fetch-pack > fmt-merge-msg > -for-each-ref > format-patch > fsck-objects > fsmonitor--daemon Everything else looks sensible, but this change is surprising as it wasn't mentioned in the commit message. I see that you changed the usage though to match what we have in the man page. That's a good change overall, but should probably be moved into a separate commit so that this commit here is not changing any behaviour. Patrick
