Re: [PATCH v4 1/2] t/t1517: automate `git subcmd -h` tests outside a repository

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Jul 26, 2025 at 5:51 PM Usman Akinyemi
<usmanakinyemi202@xxxxxxxxx> wrote:
>
> > > +for cmd in $(git --list-cmds=main)
> > > +do
> > > +       cmd=${cmd%.*} # strip .sh, .perl, etc.
> > > +       case "$cmd" in
> > > +       archimport | cvsexportcommit | cvsimport | cvsserver | daemon | \
> > > +       difftool--helper | filter-branch | fsck-objects | get-tar-commit-id | \
> > > +       http-backend | http-fetch | http-push | init-db | instaweb.sh | \
> > > +       merge-octopus | merge-one-file | merge-resolve | mergetool | \
> > > +       mktag | p4 | p4.py | pickaxe | quiltimport | remote-ftp | remote-ftps | \
> > > +       remote-http | remote-https | replay | request-pull | send-email | \
> > > +       sh-i18n--envsubst | shell | show | stage | submodule | svn | \
> > > +       upload-archive--writer | upload-pack | web--browse | whatchanged)
> >
> > Sorry, one more thing: I spot-checked a few of these, and it seems the
> > main issue that causes failures is the exit code; they seem to work
> > with "-h" outside a repo. Out of scope for this series, but something
> > worth tidying up as #leftoverbits ?
> >
> You meant the exit code of 129 right ?

Yep: some of our commands (often the ones implemented as scripts?)
don't exit 129. Fixing that is certainly out-of-scope for this
otherwise-tightly focused series.

-- 
D. Ben Knoble





[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux