[PATCH] submodule: Add a config option to skip path validation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 8 Jan 2025 20:30:00 +0100 I wrote:

Me> On Wed, 08 Jan 2025 08:03:42 -0800 Junio C Hamano <gitster@xxxxxxxxx> wrote:
[...]
Me> JCH> If the answers are no and/or yes, "submodule.validate=no" sounds like
Me> JCH> a reasonable choice, but I am not good at naming, so we may want to
Me> JCH> hear ideas from others.
Me> 
Me>  I'll wait for some time to hear if anybody else has any better suggestions.

 Hello again,

 I guess more than half a year can be considered "some time" but, anyhow,
better late than never, so here is a minimal patch implementing what I
suggested. I'm not sure if using submodule_from_path() with the global
the_repository is the right thing to do, it looks like there is an attempt
to move away from it, but I couldn't find another reasonable way to get the
config option -- using open_submodule() doesn't seem right and I don't know
what else to do. If you can propose a better way to do this, please do.

 I also couldn't find a simple way to add a test for it, I hoped to find an
existing test checking that using symlinks for submodules failed and amend
it, but either no such test exists or I've failed to find it. Again, if I
missed it, please point me to it. But for now I've just tested this
manually, with and without the option in gitconfig file.

 Please let me know if you have any other comments, thanks in advance!
VZ

--------------------------------- >8 --------------------------------------

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux