Changes: 1. Test now has an explicit error message in patch 1 2. Nice catch on the double function calls those were not needed a single function call to git_config_get_string_multi did get job done. 3. While I am at it also fixed some indentation issues (Only hoping i didn't create any unknown ones) and localized the loop variables. K Jayatheerth (2): submodule: prevent overwriting .gitmodules on path reuse submodule: skip redundant active entries when pattern covers path Documentation/git-submodule.adoc | 7 +++++ builtin/submodule--helper.c | 54 ++++++++++++++++++++++++++------ t/t7400-submodule-basic.sh | 22 +++++++++++++ t/t7413-submodule-is-active.sh | 15 +++++++++ 4 files changed, 88 insertions(+), 10 deletions(-) -- 2.50.GIT